Added stdin command handling for lazymc#81
Open
chaos-baum wants to merge 4 commits intotimvisee:masterfrom
Open
Added stdin command handling for lazymc#81chaos-baum wants to merge 4 commits intotimvisee:masterfrom
chaos-baum wants to merge 4 commits intotimvisee:masterfrom
Conversation
|
I would also like to see this added |
|
@chaos-baum @timvisee, heyo sorry for the bump, any chance this can still be tested and potentially merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I returned to personally investigate the issue I initially reported (#72 ). Since I'm not primarily a Rust developer, this journey wasn’t straightforward, but I did my best to incorporate stdin handling into the existing code.
Additionally, I conducted testing with a local Minecraft server, and so far, I haven’t encountered any significant issues or crashes.
I hope this change may be beneficial for others as well.